If at first you don’t succeed… try, try again…

Simone — Mon, 19 May 2008 14:57:02 +0000

Here’s another interesting piece of code I’ve just dug up in a C# application I’m reviewing.

If you can come up with a bright idea about what those try/catch blocks are supposed to do, you’ve got more imagination than me…

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30

class Foo
{
private int bar;

// ...snip...

public int GetNewBar()
{
int ret = 0;

lock (this)
{
try {
bar++;
ret = bar;
}
catch {
try {
bar++;
ret = bar;
}
catch {}
}
}

return ret;
}

// ...snip...
}

Don’t code like this at home, kids

Simone — Wed, 14 May 2008 08:25:13 +0000

Sometimes when you’re reviewing someone else’s code, you find interesting pieces of “art“. Like the following loop construct in a C# application:

1
2
3
4
5
6
7
8
9
10
11
12

int i = anArray.Length - 1;

while (true)
{
if (i < 0)
break;
else
{
...
i--;
}
}

Doh.

You might be tempted to rewrite it as:

1
2
3

for( int i = anArray.Length - 1; i >= 0; i-- ) {
...
}

but it would be too simple, too boring, wouldn’t it?

Simone Tellini » Coding fun

If at first you don’t succeed… try, try again…

Don’t code like this at home, kids